[webkit-reviews] review granted: [Bug 188405] [Nicosia] Add the Nicosia-specific PlatformLayer type alias : [Attachment 346759] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 8 01:43:36 PDT 2018


Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 188405: [Nicosia] Add the Nicosia-specific PlatformLayer type alias
https://bugs.webkit.org/show_bug.cgi?id=188405

Attachment 346759: Patch

https://bugs.webkit.org/attachment.cgi?id=346759&action=review




--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 346759
  --> https://bugs.webkit.org/attachment.cgi?id=346759
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346759&action=review

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
777
> +	   [&](TextureMapperPlatformLayerProxy& proxy)

Do we really need to capture everything? I prefer explicit capture and I guess
'this' is the only thing we need to capture here, no?


More information about the webkit-reviews mailing list