[webkit-reviews] review granted: [Bug 188401] [iOS] fast/events/ios/contenteditable-autocapitalize.html is a flaky failure : [Attachment 346755] Update TestExpectation

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 188401: [iOS] fast/events/ios/contenteditable-autocapitalize.html is a
flaky failure
https://bugs.webkit.org/show_bug.cgi?id=188401

Attachment 346755: Update TestExpectation

https://bugs.webkit.org/attachment.cgi?id=346755&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 346755
  --> https://bugs.webkit.org/attachment.cgi?id=346755
Update TestExpectation

View in context: https://bugs.webkit.org/attachment.cgi?id=346755&action=review

> Tools/WebKitTestRunner/ios/TestControllerIOS.mm:124
> +
> +    runUntil(m_isDoneWaitingForKeyboardToDismiss,
m_currentInvocation->shortTimeout());

Does m_isDoneWaitingForKeyboardToDismiss really need to be a member variable?
Can't it just be a static variable local to this file instead?
Alternatively, can simply hand off m_isDoneWaitingForKeyboardToDismiss as an
observer
so that we don't have to add willHideKeyboard()/didHideKeyboard() to
TestController?