[webkit-reviews] review denied: [Bug 188389] Avoid timeout resulted from calling waitUntilDone when test is not running : [Attachment 346750] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 188389: Avoid timeout resulted from calling waitUntilDone when test is not
running
https://bugs.webkit.org/show_bug.cgi?id=188389

Attachment 346750: Patch

https://bugs.webkit.org/attachment.cgi?id=346750&action=review




--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 346750
  --> https://bugs.webkit.org/attachment.cgi?id=346750
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346750&action=review

> Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:189
> +    ASSERT(!injectedBundle.isTestRunning());

This assertion looks wrong / resersed. Please run layout tests in debug locally
to make sure your assertion does not hit as we do not have wk2 debug
configuration on EWS.