[webkit-reviews] review granted: [Bug 188395] ResourceUsageOverlay should use physical footprint for its "Footprint" label : [Attachment 346748] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 188395: ResourceUsageOverlay should use physical footprint for its
"Footprint" label
https://bugs.webkit.org/show_bug.cgi?id=188395

Attachment 346748: patch

https://bugs.webkit.org/attachment.cgi?id=346748&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 346748
  --> https://bugs.webkit.org/attachment.cgi?id=346748
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346748&action=review

> Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:461
> +    if (auto footprint = memoryFootprint())

I don't like how memoryFootprint() returns an optional. This isn't normally how
we do error handling.