[webkit-reviews] review requested: [Bug 188354] Make RenderObject noncopyable : [Attachment 346649] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 7 16:15:00 PDT 2018


Chris Dumez <cdumez at apple.com> has asked  for review:
Bug 188354: Make RenderObject noncopyable
https://bugs.webkit.org/show_bug.cgi?id=188354

Attachment 346649: Patch

https://bugs.webkit.org/attachment.cgi?id=346649&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 346649
  --> https://bugs.webkit.org/attachment.cgi?id=346649
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346649&action=review

>> Source/WebCore/rendering/RenderObject.h:107
>> +	WTF_MAKE_NONCOPYABLE(RenderObject);
> 
> It is already uncopyable given this data member:
> Node& m_node;

See following review comment by Darin:
https://bugs.webkit.org/show_bug.cgi?id=158111#c45


More information about the webkit-reviews mailing list