[webkit-reviews] review granted: [Bug 188290] Add a test for using SafeBrowsing : [Attachment 346739] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 188290: Add a test for using SafeBrowsing
https://bugs.webkit.org/show_bug.cgi?id=188290

Attachment 346739: Patch

https://bugs.webkit.org/attachment.cgi?id=346739&action=review




--- Comment #10 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 346739
  --> https://bugs.webkit.org/attachment.cgi?id=346739
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346739&action=review

r=me with comment.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:136
> +    static NeverDestroyed<RetainPtr<TestLookupContext>> context;

Why NeverDestroyed with a RetainPtr? Why not the following?
static TestLookupContext *context = [[TestLookupContext alloc] init];
return context;