[webkit-reviews] review granted: [Bug 188391] [Curl] Surface additional NetworkLoadMetrics : [Attachment 346738] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 188391: [Curl] Surface additional NetworkLoadMetrics
https://bugs.webkit.org/show_bug.cgi?id=188391

Attachment 346738: Patch

https://bugs.webkit.org/attachment.cgi?id=346738&action=review




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 346738
  --> https://bugs.webkit.org/attachment.cgi?id=346738
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346738&action=review

Nice! r=me

You may be able to enable a few of the Inspector LayoutTests. Namely:
LayoutTests/http/tests/inspector/network/resource-sizes-network.html

> Source/WebCore/platform/network/curl/CurlContext.cpp:739
> +    long protocol;

This appears to be unused and can be removed.

> Source/WebCore/platform/network/curl/CurlContext.cpp:761
> +    errorCode = curl_easy_getinfo(m_handle, CURLINFO_REQUEST_SIZE,
&requestHeaderSize);

Can you subtract out the requestBodySize to get requestHeaderSize closer to the
actual value? You'd want to do some sanity checking to see if that makes sense.

> Source/WebCore/platform/network/curl/CurlContext.cpp:773
> +    errorCode = curl_easy_getinfo(m_handle, CURLINFO_SIZE_DOWNLOAD_T,
&responseBodySize);

Same here, does this include the Header Size or not? The curl docs did not seem
clear to me.