[webkit-reviews] review granted: [Bug 188348] [Nicosia] Add Nicosia::CompositionLayerTextureMapperImpl : [Attachment 346632] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 7 00:13:22 PDT 2018


Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 188348: [Nicosia] Add Nicosia::CompositionLayerTextureMapperImpl
https://bugs.webkit.org/show_bug.cgi?id=188348

Attachment 346632: Patch

https://bugs.webkit.org/attachment.cgi?id=346632&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 346632
  --> https://bugs.webkit.org/attachment.cgi?id=346632
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346632&action=review

>
Source/WebCore/platform/graphics/nicosia/texmap/NicosiaCompositionLayerTextureM
apperImpl.h:46
> +    CompositionLayerTextureMapperImpl();

Can we make this private?

>
Source/WebCore/platform/graphics/nicosia/texmap/NicosiaCompositionLayerTextureM
apperImpl.h:53
> +    CompositionState& compositionState() { return m_compositionState; }

method could be const


More information about the webkit-reviews mailing list