[webkit-reviews] review granted: [Bug 188309] NotReadableError when calling getUserMedia : [Attachment 346648] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 188309: NotReadableError when calling getUserMedia
https://bugs.webkit.org/show_bug.cgi?id=188309

Attachment 346648: Patch

https://bugs.webkit.org/attachment.cgi?id=346648&action=review




--- Comment #7 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 346648
  --> https://bugs.webkit.org/attachment.cgi?id=346648
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346648&action=review

Looks good r=me

> Source/WebKit/UIProcess/UserMediaProcessManager.cpp:151
> +    if (withAudio && !(currentExtensions &
ProcessState::SandboxExtensionsGranted::Audio)) {

All of this might be slightly easier to follow if we used a helper function to
check for extension types (e.g., "bool hasAudioExtension(unsigned
currentExtensions) { return currentExtensions & 
ProcessState::SandboxExtensionsGranted::Audio; }" and so forth).

But not needed for this bug fix.