[webkit-reviews] review granted: [Bug 188343] Make DOMWindow::scrollBy rely on DOMWindow::scrollTo : [Attachment 346620] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 188343: Make DOMWindow::scrollBy rely on DOMWindow::scrollTo
https://bugs.webkit.org/show_bug.cgi?id=188343

Attachment 346620: Patch

https://bugs.webkit.org/attachment.cgi?id=346620&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 346620
  --> https://bugs.webkit.org/attachment.cgi?id=346620
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346620&action=review

> Source/WebCore/page/DOMWindow.cpp:1595
> +    scrollToOptions.left.value() +=
view->mapFromLayoutToCSSUnits(view->contentsScrollPosition().x());
> +    scrollToOptions.top.value() +=
view->mapFromLayoutToCSSUnits(view->contentsScrollPosition().y());

I hope there are no rounding differences caused by converting from layout to
CSS and back.