[webkit-reviews] review granted: [Bug 188337] [libwebrtc] SafeSetError() in peerconnection.cc contains use-after-move of webrtc::RTCError variable : [Attachment 346609] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 6 05:51:14 PDT 2018


Eric Carlson <eric.carlson at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 188337: [libwebrtc] SafeSetError() in peerconnection.cc contains
use-after-move of webrtc::RTCError variable
https://bugs.webkit.org/show_bug.cgi?id=188337

Attachment 346609: Patch v1

https://bugs.webkit.org/attachment.cgi?id=346609&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 346609
  --> https://bugs.webkit.org/attachment.cgi?id=346609
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=346609&action=review

> Source/ThirdParty/libwebrtc/ChangeLog:4
> +	   [libwebrtc] SafeSetError() in peerconnection.cc contains
use-after-move of webrtc::RTCError variable
> +	   <https://webkit.org/b/188337>

Shouldn't this include the bugzilla link?


More information about the webkit-reviews mailing list