[webkit-reviews] review granted: [Bug 188335] [iOS] Tests that try to interact with the QuickType bar time out on iOS 11+ : [Attachment 346610] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 188335: [iOS] Tests that try to interact with the QuickType bar time out on
iOS 11+
https://bugs.webkit.org/show_bug.cgi?id=188335

Attachment 346610: Patch

https://bugs.webkit.org/attachment.cgi?id=346610&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 346610
  --> https://bugs.webkit.org/attachment.cgi?id=346610
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346610&action=review

> LayoutTests/ChangeLog:27
> +	   Add a new UIHelper method to type a character using the keyboard.
Sends hardware keyboard events on the WebKit2
> +	   port of iOS, and uses EventSender elsewhere.

Should we just make EventSender work so the tests don't have to mind? Does that
even make sense? (like, is it possible to hide this behind the existing
interface)