[webkit-reviews] review granted: [Bug 187455] Make WebCore::Timer more space-efficient : [Attachment 346592] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 187455: Make WebCore::Timer more space-efficient
https://bugs.webkit.org/show_bug.cgi?id=187455

Attachment 346592: Patch

https://bugs.webkit.org/attachment.cgi?id=346592&action=review




--- Comment #5 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 346592
  --> https://bugs.webkit.org/attachment.cgi?id=346592
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346592&action=review

> Source/WebCore/platform/Timer.h:101
> +    signed int m_heapIndex : 31; // -1 if not in heap

We basically lose one bit for sign, I wonder if we could pack the “not in heap”
state as a bool, too, to avoid magic number code,

> Source/WebCore/platform/Timer.h:102
> +    bool m_wasDeleted : 1;

Nice!