[webkit-reviews] review granted: [Bug 188290] Add SPI to test safe browsing : [Attachment 346506] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 188290: Add SPI to test safe browsing
https://bugs.webkit.org/show_bug.cgi?id=188290

Attachment 346506: Patch

https://bugs.webkit.org/attachment.cgi?id=346506&action=review




--- Comment #7 from Tim Horton <thorton at apple.com> ---
Comment on attachment 346506
  --> https://bugs.webkit.org/attachment.cgi?id=346506
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346506&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:5875
> +	   handler.get()(url,
BlockPtr<void(BOOL)>::fromCallable([completionHandler =
WTFMove(completionHandler)] (BOOL phishing) mutable {

should this be "isUnsafe" or something?

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:5876
> +	       completionHandler({{ "MockSafeBrowsingProvider"_s, !!phishing,
false, false, false }});

why the !!