[webkit-reviews] review granted: [Bug 188235] If there's a radar in the changelog, webkit-patch upload/create-bug should put the radar in the bug and set InRadar : [Attachment 346422] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Lucas Forschler
<lforschler at apple.com>'s request for review:
Bug 188235: If there's a radar in the changelog, webkit-patch upload/create-bug
should put the radar in the bug and set InRadar
https://bugs.webkit.org/show_bug.cgi?id=188235

Attachment 346422: Patch

https://bugs.webkit.org/attachment.cgi?id=346422&action=review




--- Comment #11 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 346422
  --> https://bugs.webkit.org/attachment.cgi?id=346422
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346422&action=review

> Tools/Scripts/webkitpy/common/checkout/changelog.py:117
> +    def _parse_radar_id(cls, text):

The matching in this function and the regex we are using seem too generous
because they seem to search for a rdar-looking URL anywhere. I suggest we take
a similar approach as in parse_bug_id_from_changelog() and restrict matching to
a radar-like URL with zero or more leading whitespace from the start of a
ChangeLog line. We should also add test cases for this.

> Tools/Scripts/webkitpy/tool/steps/addradar.py:40
> +	   if state.get("created_new_bug") != True:

Remove the “!= True” and add “not” after “if”.