[webkit-reviews] review granted: [Bug 188295] [ews-build] Add build step to Check Patch Relevance : [Attachment 346500] Proposed patch

[bugzilla-daemon at webkit.org]

Lucas Forschler <lforschler at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 188295: [ews-build] Add build step to Check Patch Relevance
https://bugs.webkit.org/show_bug.cgi?id=188295

Attachment 346500: Proposed patch

https://bugs.webkit.org/attachment.cgi?id=346500&action=review




--- Comment #3 from Lucas Forschler <lforschler at apple.com> ---
Comment on attachment 346500
  --> https://bugs.webkit.org/attachment.cgi?id=346500
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346500&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:116
> +

Please add a comment that these paths came from
https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/tool/steps/
checkpatchrelevance.py#L41
It would be nice if we only had one place in source for this knowledge to live.
As it is now, someone will need to keep the two in sync.
Maybe we can have future unit test check to ensure they contain the same data?

> Tools/BuildSlaveSupport/ews-build/steps.py:154
> +	       # This build doesn't have an patch, it might be a force build.

nit: this build doesn't have "a" patch