[webkit-reviews] review denied: [Bug 188145] Hardcoded LFENCE instruction : [Attachment 346059] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied karogyoker2+webkit at gmail.com's
request for review:
Bug 188145: Hardcoded LFENCE instruction
https://bugs.webkit.org/show_bug.cgi?id=188145

Attachment 346059: Patch

https://bugs.webkit.org/attachment.cgi?id=346059&action=review




--- Comment #16 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 346059
  --> https://bugs.webkit.org/attachment.cgi?id=346059
Patch

This change is wrong because cpuid is dramatically slower than lfence and
because lfence is no longer the way we are mitigating Spectre.	We should just
remove all uses of speculationFence() and remove speculationFence().