[webkit-reviews] review granted: [Bug 187998] [WPE] Implement MouseEvent.buttons : [Attachment 346464] Patch

[bugzilla-daemon at webkit.org]

Zan Dobersek <zan at falconsigh.net> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 187998: [WPE] Implement MouseEvent.buttons
https://bugs.webkit.org/show_bug.cgi?id=187998

Attachment 346464: Patch

https://bugs.webkit.org/attachment.cgi?id=346464&action=review




--- Comment #7 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 346464
  --> https://bugs.webkit.org/attachment.cgi?id=346464
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346464&action=review

> Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:94
> +    case 1:
> +	   modifier = wpe_input_pointer_modifier_button1;
> +	   break;

Can these return the relevant modifier value, and the default clause just
return 0? Or, if the compiler complains, have the default clause break and then
return by default?