[webkit-reviews] review granted: [Bug 187108] Add configuration for automatic process pre-warming : [Attachment 346447] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Ben Richards
<benton_richards at apple.com>'s request for review:
Bug 187108: Add configuration for automatic process pre-warming
https://bugs.webkit.org/show_bug.cgi?id=187108

Attachment 346447: Patch

https://bugs.webkit.org/attachment.cgi?id=346447&action=review




--- Comment #38 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 346447
  --> https://bugs.webkit.org/attachment.cgi?id=346447
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346447&action=review

> Source/WebKit/UIProcess/WebProcessPool.cpp:1336
> +    

Nit: Whitespace here.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/InitialWarmedProcessUsed.mm:43
> +    

Nit: Whitespace.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/InitialWarmedProcessUsed.mm:46
> +    

Ditto.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/InitialWarmedProcessUsed.mm:50
> +    

Ditto.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/InitialWarmedProcessUsed.mm:52
> +    

Ditto.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/InitialWarmedProcessUsed.mm:58
> +    

Ditto.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/SetMaximumPrewarmedProcessCount.mm:41
> +    

Nit: Whitespace.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/SetMaximumPrewarmedProcessCount.mm:43
> +    

Ditto.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/SetMaximumPrewarmedProcessCount.mm:45
> +    

Ditto.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/SetMaximumPrewarmedProcessCount.mm:47
> +    

Ditto.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/SetMaximumPrewarmedProcessCount.mm:49
> +    

Ditto.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/SetMaximumPrewarmedProcessCount.mm:51
> +    

Ditto.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/SetMaximumPrewarmedProcessCount.mm:53
> +    

Ditto.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/SetMaximumPrewarmedProcessCount.mm:55
> +    

Ditto.

> ChangeLog:8
> +	   * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:

Let's revert this change.