[webkit-reviews] review granted: [Bug 188292] PDFPlugin: Context menus in RTL are left-aligned : [Attachment 346434] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 188292: PDFPlugin: Context menus in RTL are left-aligned
https://bugs.webkit.org/show_bug.cgi?id=188292

Attachment 346434: Patch

https://bugs.webkit.org/attachment.cgi?id=346434&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 346434
  --> https://bugs.webkit.org/attachment.cgi?id=346434
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346434&action=review

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:1610
> +    auto itemCount = [nsMenu numberOfItems];
> +    for (int i = 0; i < itemCount; i++) {

auto considered harmful: are you going to get signed/unsigned comparison
warnings here or not?

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:1619
> +    std::optional<int> selectedIndex = -1;

optional<> but init with -1? Why not optional<optional<>> (j/k)