[webkit-reviews] review denied: [Bug 188095] Transition more WKWebViewConfiguration ivars to API::PageConfiguration : [Attachment 345923] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 2 13:04:48 PDT 2018


Sam Weinig <sam at webkit.org> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 188095: Transition more WKWebViewConfiguration ivars to
API::PageConfiguration
https://bugs.webkit.org/show_bug.cgi?id=188095

Attachment 345923: Patch

https://bugs.webkit.org/attachment.cgi?id=345923&action=review




--- Comment #4 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 345923
  --> https://bugs.webkit.org/attachment.cgi?id=345923
Patch

Historically we have tried to keep the configuration and preferences separate
other than when the values in the configuration initialize the preference
values. I think we should try to preserve that behavior during this transition.


More information about the webkit-reviews mailing list