[webkit-reviews] review granted: [Bug 188242] httpCookieStore.getAllCookies() does not always call completion block : [Attachment 346310] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 188242: httpCookieStore.getAllCookies() does not always call completion
block
https://bugs.webkit.org/show_bug.cgi?id=188242

Attachment 346310: Patch

https://bugs.webkit.org/attachment.cgi?id=346310&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 346310
  --> https://bugs.webkit.org/attachment.cgi?id=346310
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346310&action=review

r=me with nits.

> Source/WebKit/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=188242

Is there a radar tracking this as well?

> Source/WebKit/UIProcess/GenericCallback.h:199
>      CallbackID put(Function<void(T...)>&& function)

Is anyone still relying on this overload? If not, we should probably drop it.

> Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:113
> +    auto callbackID = m_callbacks.put(WTFMove(callbackFunction),
processPool()->networkProcess()->throttler().backgroundActivityToken());

processPool()->ensureNetworkProcess().throttler().backgroundActivityToken()
Then omit the line above.

> Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:140
> +    processPool()->ensureNetworkProcess();

ditto.

> Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:147
> +    processPool()->ensureNetworkProcess();

ditto.

> Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:154
> +    processPool()->ensureNetworkProcess();

ditto.

> Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:161
> +    processPool()->ensureNetworkProcess();

ditto.

> Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:168
> +    processPool()->ensureNetworkProcess();

ditto.

> Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:175
> +    processPool()->ensureNetworkProcess();

ditto.

> Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:262
> +    processPool()->ensureNetworkProcess();

ditto.

> Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:269
> +    processPool()->ensureNetworkProcess();

ditto.