[webkit-reviews] review granted: [Bug 188250] Use WTF::Variant for WebPreferencesStore::Value : [Attachment 346395] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 188250: Use WTF::Variant for WebPreferencesStore::Value
https://bugs.webkit.org/show_bug.cgi?id=188250

Attachment 346395: Patch

https://bugs.webkit.org/attachment.cgi?id=346395&action=review




--- Comment #5 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 346395
  --> https://bugs.webkit.org/attachment.cgi?id=346395
Patch

Looks good. I think this would be a great opportunity to add tests to
TestWebKitAPI for ArgumentCoder.  As you will see, the name TestWebKitAPI is a
bit misleading, as we have many tests for WTF and WebCore types that aren't
actually exposed as API, and are really just good old unit tests.