[webkit-reviews] review granted: [Bug 188226] Optionally expose Attr::style to JavaScript : [Attachment 346298] Expose Attr::style to JS when _WKProcessPoolConfiguration.attrStyleEnabled is YES

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted mitz at webkit.org's request for review:
Bug 188226: Optionally expose Attr::style to JavaScript
https://bugs.webkit.org/show_bug.cgi?id=188226

Attachment 346298: Expose Attr::style to JS when
_WKProcessPoolConfiguration.attrStyleEnabled is YES

https://bugs.webkit.org/attachment.cgi?id=346298&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 346298
  --> https://bugs.webkit.org/attachment.cgi?id=346298
Expose Attr::style to JS when _WKProcessPoolConfiguration.attrStyleEnabled is
YES

This comment in Attr.cpp is now inaccurate:

CSSStyleDeclaration* Attr::style()
{
    // This function only exists to support the Obj-C bindings.

I suggest either removing the comment or replacing the comment with something
that helps explain what context we might want to make this public (possibly
handy for JavaScript code implementing editing operations for apps like Mail)
and what context we should not (non-standard, not intended to be part of the
web platform).