[webkit-reviews] review granted: [Bug 188203] Hardcode some system colors to avoid fingerprinting exposure : [Attachment 346254] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 1 11:40:38 PDT 2018


Tim Horton <thorton at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 188203: Hardcode some system colors to avoid fingerprinting exposure
https://bugs.webkit.org/show_bug.cgi?id=188203

Attachment 346254: Patch

https://bugs.webkit.org/attachment.cgi?id=346254&action=review




--- Comment #19 from Tim Horton <thorton at apple.com> ---
Comment on attachment 346254
  --> https://bugs.webkit.org/attachment.cgi?id=346254
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346254&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:768
> +		   return Color(0x4C1AA9FF, Color::Semantic);

You could neaten this up with the ternary operator but maybe this is easier to
read.


More information about the webkit-reviews mailing list