[webkit-reviews] review granted: [Bug 188194] [GStreamer] Dynamically adjust blocksize : [Attachment 346165] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Charlie Turner
<cturner at igalia.com>'s request for review:
Bug 188194: [GStreamer] Dynamically adjust blocksize
https://bugs.webkit.org/show_bug.cgi?id=188194

Attachment 346165: Patch

https://bugs.webkit.org/attachment.cgi?id=346165&action=review




--- Comment #3 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 346165
  --> https://bugs.webkit.org/attachment.cgi?id=346165
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346165&action=review

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:60
> +    static constexpr int growBlocksizeLimit { 1 };
> +    static constexpr int growBlocksizeCount { 1 };
> +    static constexpr int growBlocksizeFactor { 2 };
> +    static constexpr float reduceBlocksizeLimit { 0.20 };
> +    static constexpr int reduceBlocksizeCount { 2 };
> +    static constexpr float reduceBlocksizeFactor { 0.5 };

These should be prefixed with s_

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:784
> +	   m_reduceBlocksizeCount = m_increaseBlocksizeCount = 0;

Please, write this in two lines.