[webkit-reviews] review granted: [Bug 185151] B3::demoteValues should be able to handle patchpoint terminals : [Attachment 339168] the patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 185151: B3::demoteValues should be able to handle patchpoint terminals
https://bugs.webkit.org/show_bug.cgi?id=185151

Attachment 339168: the patch

https://bugs.webkit.org/attachment.cgi?id=339168&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 339168
  --> https://bugs.webkit.org/attachment.cgi?id=339168
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339168&action=review

r=me

> Source/JavaScriptCore/b3/B3BreakCriticalEdges.cpp:44
> +	   // Non-void terminals that are the moral equivalent of jumps trigger
critical edge braking
> +	   // because of fixSSA's demoteValues.

"of jumps trigger" => "of jumps that trigger"
"braking" => "breaking"

I would also say instead of "because of fixSSA's demote values" something like
"fixSSA's demote values relies on this invariant"

> Source/JavaScriptCore/b3/B3FixSSA.cpp:306
> +	       if (variable) {

I think some comment saying this is for terminal patchpoints that are non void
might make whoever reads this code in ~6months happier.