[webkit-reviews] review granted: [Bug 185144] Add tests for selection in content editable : [Attachment 339153] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 30 17:31:43 PDT 2018


Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 185144: Add tests for selection in content editable
https://bugs.webkit.org/show_bug.cgi?id=185144

Attachment 339153: Patch

https://bugs.webkit.org/attachment.cgi?id=339153&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 339153
  --> https://bugs.webkit.org/attachment.cgi?id=339153
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339153&action=review

>
LayoutTests/fast/events/touch/ios/double-tap-on-editable-content-for-selection-
then-drag-down-to-change-selected-text.html:15
> +		   return;

Nit - we usually insert a message here by doing something like
`description("This test is best run under WebKitTestRunner.")`.


More information about the webkit-reviews mailing list