[webkit-reviews] review granted: [Bug 184720] Improve the performance of FontCascadeDescription's effectiveFamilies : [Attachment 339159] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 184720: Improve the performance of FontCascadeDescription's
effectiveFamilies
https://bugs.webkit.org/show_bug.cgi?id=184720

Attachment 339159: Patch

https://bugs.webkit.org/attachment.cgi?id=339159&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 339159
  --> https://bugs.webkit.org/attachment.cgi?id=339159
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339159&action=review

> Source/WebCore/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=184720

Radar number.

> Source/WebCore/ChangeLog:9
> +	   with roughly few number of individual fonts. It turns out we were
calling into the system-ui

"with roughly few number" ?

> Source/WebCore/ChangeLog:11
> +	   https://bugs.webkit.org/show_bug.cgi?id=175845). These data URLS are
never for the system font,

are never what?