[webkit-reviews] review granted: [Bug 185101] Move StructureIsImmortal to out of line flags. : [Attachment 339139] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 30 13:07:12 PDT 2018


Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 185101: Move StructureIsImmortal to out of line flags.
https://bugs.webkit.org/show_bug.cgi?id=185101

Attachment 339139: Patch

https://bugs.webkit.org/attachment.cgi?id=339139&action=review




--- Comment #8 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 339139
  --> https://bugs.webkit.org/attachment.cgi?id=339139
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339139&action=review

> Source/JavaScriptCore/runtime/JSTypeInfo.h:45
>  static const unsigned OverridesToThis = 1 << 6; // If this is false then
this returns something other than 'this'. Non-object cells that are visible to
JS have this set as do some exotic objects.
>  static const unsigned HasStaticPropertyTable = 1 << 7;

Why not slide these down?


More information about the webkit-reviews mailing list