[webkit-reviews] review denied: [Bug 185125] REGRESSION(r230960): Browser tests under TimeSeriesChart fetchMeasurementSets all fail : [Attachment 339113] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied dewei_zhu at apple.com's request for
review:
Bug 185125: REGRESSION(r230960): Browser tests under TimeSeriesChart
fetchMeasurementSets all fail
https://bugs.webkit.org/show_bug.cgi?id=185125

Attachment 339113: Patch

https://bugs.webkit.org/attachment.cgi?id=339113&action=review




--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 339113
  --> https://bugs.webkit.org/attachment.cgi?id=339113
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339113&action=review

> Websites/perf.webkit.org/unit-tests/resources/mock-remote-api.js:67
> +	   const PrivilegedAPI = useNodePrivilegedAPI ?
> +	       require('../../tools/js/privileged-api').PrivilegedAPI :
require('../../public/v3/privileged-api.js').PrivilegedAPI;

This is not right as it would end up loading PrivilegedAPI each time inject is
called.