[webkit-reviews] review granted: [Bug 184699] [GTK] Generate a JSC bundle on the 64 and 32 bit release bots and upload it to webkitgtk.org : [Attachment 338136] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Carlos Alberto Lopez Perez
<clopez at igalia.com>'s request for review:
Bug 184699: [GTK] Generate a JSC bundle on the 64 and 32 bit release bots and
upload it to webkitgtk.org
https://bugs.webkit.org/show_bug.cgi?id=184699

Attachment 338136: Patch

https://bugs.webkit.org/attachment.cgi?id=338136&action=review




--- Comment #6 from Gustavo Noronha (kov) <gns at gnome.org> ---
Comment on attachment 338136
  --> https://bugs.webkit.org/attachment.cgi?id=338136
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338136&action=review

LGTM, and I installed the packages and deployed the file in 32bot =) sorry for
the delay!

> Tools/Scripts/generate-jsc-bundle:124
> +    # Clean everthing from previous runs

everything*

> Tools/Scripts/generate-jsc-bundle:142
> +    # jsvu project preffers .zip rather than .tar.xz

prefers*

Interesting, I wasn't aware of jsvu =)