[webkit-reviews] review granted: [Bug 185052] [Cocoa] Set HTTPOnly flag when converting Cookie to NSHTTPCookie : [Attachment 339042] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 28 22:00:41 PDT 2018


Geoffrey Garen <ggaren at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 185052: [Cocoa] Set HTTPOnly flag when converting Cookie to NSHTTPCookie
https://bugs.webkit.org/show_bug.cgi?id=185052

Attachment 339042: Patch

https://bugs.webkit.org/attachment.cgi?id=339042&action=review




--- Comment #4 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 339042
  --> https://bugs.webkit.org/attachment.cgi?id=339042
Patch

r=me

Hard to tell whether this is an EWS pass or fail. mac-debug looks like a pass,
with some pre-existing failures. gtk-wk2 and woe look like the builder needs a
reboot. So, I'll say cq+.


More information about the webkit-reviews mailing list