[webkit-reviews] review granted: [Bug 185100] Add logging when SpringBoard enables WebThread : [Attachment 339043] Patch v1

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 185100: Add logging when SpringBoard enables WebThread
https://bugs.webkit.org/show_bug.cgi?id=185100

Attachment 339043: Patch v1

https://bugs.webkit.org/attachment.cgi?id=339043&action=review




--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 339043
  --> https://bugs.webkit.org/attachment.cgi?id=339043
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=339043&action=review

> Source/WTF/ChangeLog:5
> +	   <rdar://problem/39746542>

I assume if I were to look at this bug that it would explain why it is
beneficial to add this logging.

> Source/WTF/wtf/Platform.h:-1266
> -/* FIXME: Enable USE_OS_LOG when building with the public iOS 10 SDK once we
fix <rdar://problem/27758343>. */

Not at my computer. I am assuming we fixed the referenced radar and hence we
can enable this. The ChangeLog didn’t mention this fact and EWS failed to
compile this patch for iOS due to another issue below.

> Source/WebCore/platform/ios/wak/WebCoreThread.mm:880
> +	   RELEASE_LOG_FAULT(Threading, "SpringBoard enabled WebThread.");

According to the EWS we don’t have a logging channel called Threading.