[webkit-reviews] review granted: [Bug 185049] [WinCairo] Support --no-copy for jsc tests in wincairo tests, add copying of dlls for copy case : [Attachment 338916] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 27 14:14:47 PDT 2018
Keith Miller <keith_miller at apple.com> has granted Stephan Szabo
<stephan.szabo at sony.com>'s request for review:
Bug 185049: [WinCairo] Support --no-copy for jsc tests in wincairo tests, add
copying of dlls for copy case
https://bugs.webkit.org/show_bug.cgi?id=185049
Attachment 338916: Patch
https://bugs.webkit.org/attachment.cgi?id=338916&action=review
--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 338916
--> https://bugs.webkit.org/attachment.cgi?id=338916
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=338916&action=review
seems reasonable. r=me with some comments.
> Tools/Scripts/run-jsc-stress-tests:1581
> + if !$remote and !$tarball
Nit: Please remove this whitespace?
More information about the webkit-reviews
mailing list