[webkit-reviews] review granted: [Bug 185066] PSON: Triggering a navigation to an invalid URL creates a new WebContent process : [Attachment 338966] Fixes the bug

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 185066: PSON: Triggering a navigation to an invalid URL creates a new
WebContent process
https://bugs.webkit.org/show_bug.cgi?id=185066

Attachment 338966: Fixes the bug

https://bugs.webkit.org/attachment.cgi?id=338966&action=review




--- Comment #6 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 338966
  --> https://bugs.webkit.org/attachment.cgi?id=338966
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=338966&action=review

> Source/WebKit/UIProcess/WebProcessPool.cpp:2099
> +    if (!url.isValid() || !targetURL.isValid() || url.isEmpty() ||
url.isBlankURL() || protocolHostAndPortAreEqual(url, targetURL))

Since the check is related to targetURL, it might be clearer to update
shouldTreatAsSameOriginNavigation so that
navigation.treatAsSameOriginNavigation() handles this case.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:62
> +bool didRecieveAlert;

s/didRecieveAlert/didReceiveAlert/

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:145
> +    alertMessage = message;

It seems alertMessage is never used.
Are you planning to use it later on or should it be removed?