[webkit-reviews] review denied: [Bug 185045] Add Support for a Download Build Product Script : [Attachment 339013] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Amal Hussein <amal at bocoup.com>'s
request for review:
Bug 185045: Add Support for a Download Build Product Script
https://bugs.webkit.org/show_bug.cgi?id=185045

Attachment 339013: Patch

https://bugs.webkit.org/attachment.cgi?id=339013&action=review




--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 339013
  --> https://bugs.webkit.org/attachment.cgi?id=339013
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339013&action=review

This clearly needs to share code with ./Tools/Scripts/bisect-builds. In fact,
we have very similarly named script:
Tools/BuildSlaveSupport/download-built-product

I don't think we should land this script as is.

> Tools/Scripts/download-build-product.py:49
> +	       optparse.make_option('--revision', type='str', default=None,
> +				    help=('Pass in a build revision number from
WebKit archives to download binaries. Revision=None will download the latest
build.'))]),

Nit: wrong indentation. We always use 4 spaces, and never align to ( or any
other punctuation.