[webkit-reviews] review granted: [Bug 185032] [LFC] Formatting contexts should create floating states. : [Attachment 338881] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 185032: [LFC] Formatting contexts should create floating states.
https://bugs.webkit.org/show_bug.cgi?id=185032

Attachment 338881: Patch

https://bugs.webkit.org/attachment.cgi?id=338881&action=review




--- Comment #5 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 338881
  --> https://bugs.webkit.org/attachment.cgi?id=338881
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338881&action=review

> Source/WebCore/layout/layouttree/LayoutBox.cpp:140
> +    // Initial containing block always establishes a formatting context.
> +    ASSERT_NOT_REACHED();
> +    return nullptr;

Could this return Container& instead of *?