[webkit-reviews] review granted: [Bug 185050] [Extra zoom mode] Add a mechanism to override default viewport behaviors in extra zoom mode : [Attachment 338953] Part 1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 26 20:31:01 PDT 2018


Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 185050: [Extra zoom mode] Add a mechanism to override default viewport
behaviors in extra zoom mode
https://bugs.webkit.org/show_bug.cgi?id=185050

Attachment 338953: Part 1

https://bugs.webkit.org/attachment.cgi?id=338953&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 338953
  --> https://bugs.webkit.org/attachment.cgi?id=338953
Part 1

View in context: https://bugs.webkit.org/attachment.cgi?id=338953&action=review

> Source/WebKit/UIProcess/ios/WKContentView.mm:-405
> -	   _webView._forceHorizontalViewportShrinkToFit,

Nice! It is too rare that one of these parameters is red instead of green :)

> Tools/ChangeLog:9
> +	   Remove an test that's no longer useful, now that the SPI it was
testing is gone. This functionality is now

an test!


More information about the webkit-reviews mailing list