[webkit-reviews] review granted: [Bug 184843] tex[Sub]Image2D slow when passing in a <canvas>, faster with ImageData : [Attachment 338682] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Justin Fan
<justin_fan at apple.com>'s request for review:
Bug 184843: tex[Sub]Image2D slow when passing in a <canvas>, faster with
ImageData
https://bugs.webkit.org/show_bug.cgi?id=184843

Attachment 338682: Patch

https://bugs.webkit.org/attachment.cgi?id=338682&action=review




--- Comment #13 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 338682
  --> https://bugs.webkit.org/attachment.cgi?id=338682
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338682&action=review

> Source/WebCore/ChangeLog:11
> +	   This improves this rendering path by a factor of ~4. The rest of
FormatConverter may require similar improvements.

The best thing to do here would be to file a bugzilla bug for the rest of the
improvements, and reference it. Like "Filed webkit.org/b/9999 for further
improvements".

> Source/WebCore/platform/graphics/FormatConverter.cpp:1265
> +	   // FIXME: Experimental Accelerate Alpha Unmultiplicaton for this
specific case; general performance improvements later.

Remove the comment. It only means something to you.