[webkit-reviews] review granted: [Bug 184938] -[WKHTTPCookieStore deleteCookie:completionHandler:] doesn't delete cookies : [Attachment 338846] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 184938: -[WKHTTPCookieStore deleteCookie:completionHandler:] doesn't delete
cookies
https://bugs.webkit.org/show_bug.cgi?id=184938

Attachment 338846: Patch

https://bugs.webkit.org/attachment.cgi?id=338846&action=review




--- Comment #10 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 338846
  --> https://bugs.webkit.org/attachment.cgi?id=338846
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338846&action=review

r=me

> Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:70
> +    NSArray *nsCookies = [nsCookieStorage() cookies];
> +    for (NSHTTPCookie *nsCookie in nsCookies) {
> +	   if (Cookie(nsCookie) == cookie) {
> +	       [nsCookieStorage() deleteCookie:nsCookie];
> +	       break;
> +	   }
> +    }

Unlike the change to operator== above, which is a nice improvement that we
would do intentionally, this change is a purely a workaround, which we'd rather
not preserve. So, please do follow up and fix the Cookie => NSHTTPCookie
conversion path, and when you do, you can remove this workaround.