[webkit-reviews] review granted: [Bug 185017] Activate selection when interacting with editable content : [Attachment 338852] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 26 10:53:10 PDT 2018


Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 185017: Activate selection when interacting with editable content
https://bugs.webkit.org/show_bug.cgi?id=185017

Attachment 338852: Patch

https://bugs.webkit.org/attachment.cgi?id=338852&action=review




--- Comment #10 from Tim Horton <thorton at apple.com> ---
Comment on attachment 338852
  --> https://bugs.webkit.org/attachment.cgi?id=338852
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338852&action=review

>
LayoutTests/fast/events/touch/ios/double-tap-on-editable-content-for-selection-
then-drag-right-to-change-selected-text.html:12
> +	   //setTimeout(function(){testRunner.notifyDone()},2000);

What's this!

>
LayoutTests/fast/events/touch/ios/double-tap-on-editable-content-for-selection-
then-drag-right-to-change-selected-text.html:90
> +	       var editableElement =document.getElementById('editable');

Space after = :P


More information about the webkit-reviews mailing list