[webkit-reviews] review denied: [Bug 185030] Token misspelled "tocken" in error message string : [Attachment 338885] Fix typo "tocken" => "token" in SyntaxError message string

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 26 10:18:53 PDT 2018


Mark Lam <mark.lam at apple.com> has denied rwaldron <rick at bocoup.com>'s request
for review:
Bug 185030: Token misspelled "tocken" in error message string
https://bugs.webkit.org/show_bug.cgi?id=185030

Attachment 338885: Fix typo "tocken" => "token" in SyntaxError message string

https://bugs.webkit.org/attachment.cgi?id=338885&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 338885
  --> https://bugs.webkit.org/attachment.cgi?id=338885
Fix typo "tocken" => "token" in SyntaxError message string

View in context: https://bugs.webkit.org/attachment.cgi?id=338885&action=review

> JSTests/ChangeLog:390
> -	   
> +

Please change your editor to not automatically strip leading spaces like these.
 It makes your patch a lot less readable.  Can you please redo your patch
without all of these accidental leading space removals?  It's ok to remove some
if the leading space is on lines of code immediately adjacent too your changes.
 It's not ok to remove all leading spaces elsewhere in the file.  Thanks.


More information about the webkit-reviews mailing list