[webkit-reviews] review granted: [Bug 185000] Add port 548 (afpovertcp) to port blacklist : [Attachment 338800] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 185000: Add port 548 (afpovertcp) to port blacklist
https://bugs.webkit.org/show_bug.cgi?id=185000

Attachment 338800: Patch

https://bugs.webkit.org/attachment.cgi?id=338800&action=review




--- Comment #4 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 338800
  --> https://bugs.webkit.org/attachment.cgi?id=338800
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338800&action=review

r=me

> LayoutTests/platform/gtk/security/block-test-expected.txt:151
>  http://255.255.255.255:6697/test.jpg - didFailLoadingWithError: <NSError
domain WebKitErrorDomain, code 103, failing URL
"http://255.255.255.255:6697/test.jpg">
>  http://255.255.255.255:65535/test.jpg - willSendRequest <NSURLRequest URL
http://255.255.255.255:65535/test.jpg, main document URL block-test.html, http
method GET> redirectResponse (null)
>  http://255.255.255.255:65535/test.jpg - didFailLoadingWithError: <NSError
domain WebKitErrorDomain, code 103, failing URL
"http://255.255.255.255:65535/test.jpg">
> -http://255.255.255.255:65536/test.jpg - willSendRequest <NSURLRequest URL
http://255.255.255.255:65536/test.jpg, main document URL block-test.html, http
method GET> redirectResponse (null)
> -http://255.255.255.255:65536/test.jpg - didFailLoadingWithError: <NSError
domain WebKitErrorDomain, code 103, failing URL
"http://255.255.255.255:65536/test.jpg">
> -http://255.255.255.255:4294967295/test.jpg - willSendRequest <NSURLRequest
URL http://255.255.255.255:4294967295/test.jpg, main document URL
block-test.html, http method GET> redirectResponse (null)
> -http://255.255.255.255:4294967295/test.jpg - didFailLoadingWithError:
<NSError domain WebKitErrorDomain, code 103, failing URL
"http://255.255.255.255:4294967295/test.jpg">
> +http://255.255.255.255:0/test.jpg - willSendRequest <NSURLRequest URL
http://255.255.255.255:0/test.jpg, main document URL block-test.html, http
method GET> redirectResponse (null)
> +http://255.255.255.255:0/test.jpg - didFailLoadingWithError: <NSError domain
NSURLErrorDomain, code -1004, failing URL "http://255.255.255.255:0/test.jpg">
>  http://255.255.255.255/test.jpg - willSendRequest <NSURLRequest URL
http://255.255.255.255/test.jpg, main document URL block-test.html, http method
GET> redirectResponse (null)
> -http://255.255.255.255/test.jpg - didFailLoadingWithError: <NSError domain
NSURLErrorDomain, code 4, failing URL
"http://255.255.255.255:4294967296/test.jpg">
> +http://255.255.255.255/test.jpg - didFailLoadingWithError: <NSError domain
NSURLErrorDomain, code -1004, failing URL "http://255.255.255.255/test.jpg">
>  http://255.255.255.255/test.jpg - willSendRequest <NSURLRequest URL
http://255.255.255.255/test.jpg, main document URL block-test.html, http method
GET> redirectResponse (null)
> -http://255.255.255.255/test.jpg - didFailLoadingWithError: <NSError domain
NSURLErrorDomain, code 4, failing URL "http://255.255.255.255:0/test.jpg">
> -http://255.255.255.255/test.jpg - willSendRequest <NSURLRequest URL
http://255.255.255.255/test.jpg, main document URL block-test.html, http method
GET> redirectResponse (null)
> -http://255.255.255.255/test.jpg - didFailLoadingWithError: <NSError domain
NSURLErrorDomain, code 4, failing URL "http://255.255.255.255/test.jpg">
> -http://255.255.255.255/test.jpg - willSendRequest <NSURLRequest URL
http://255.255.255.255/test.jpg, main document URL block-test.html, http method
GET> redirectResponse (null)
> -http://255.255.255.255/test.jpg - didFailLoadingWithError: <NSError domain
NSURLErrorDomain, code 4, failing URL "http://255.255.255.255/test.jpg">
> +http://255.255.255.255/test.jpg - didFailLoadingWithError: <NSError domain
NSURLErrorDomain, code -1004, failing URL "http://255.255.255.255/test.jpg">
>  ftp://255.255.255.255/test.jpg - willSendRequest <NSURLRequest URL
ftp://255.255.255.255/test.jpg, main document URL block-test.html, http method
GET> redirectResponse (null)
> -ftp://255.255.255.255/test.jpg - didFailLoadingWithError: <NSError domain
WebKitErrorDomain, code 101, failing URL "ftp://255.255.255.255/test.jpg">
> +ftp://255.255.255.255/test.jpg - didFailLoadingWithError: <NSError domain
NSURLErrorDomain, code -1, failing URL "ftp://255.255.255.255/test.jpg">
>  ftp://255.255.255.255/test.jpg - willSendRequest <NSURLRequest URL
ftp://255.255.255.255/test.jpg, main document URL block-test.html, http method
GET> redirectResponse (null)
> -ftp://255.255.255.255/test.jpg - didFailLoadingWithError: <NSError domain
WebKitErrorDomain, code 101, failing URL "ftp://255.255.255.255/test.jpg">
> +ftp://255.255.255.255/test.jpg - didFailLoadingWithError: <NSError domain
NSURLErrorDomain, code -1, failing URL "ftp://255.255.255.255/test.jpg">
>  ftp://255.255.255.255:22/test.jpg - willSendRequest <NSURLRequest URL
ftp://255.255.255.255:22/test.jpg, main document URL block-test.html, http
method GET> redirectResponse (null)
> -ftp://255.255.255.255:22/test.jpg - didFailLoadingWithError: <NSError domain
WebKitErrorDomain, code 101, failing URL "ftp://255.255.255.255:22/test.jpg">
> +ftp://255.255.255.255:22/test.jpg - didFailLoadingWithError: <NSError domain
NSURLErrorDomain, code -1, failing URL "ftp://255.255.255.255:22/test.jpg">

Where these changes taken from a GTK buildbot?	Seems like the test results
haven't been updated in a while (which is okay; just curious why there are so
many changes).

> LayoutTests/platform/wpe/security/block-test-expected.txt:151
> -http://255.255.255.255:0/test.jpg - didFailLoadingWithError: <NSError domain
soup_http_error_quark, code 4, failing URL "http://255.255.255.255/test.jpg">
> +http://255.255.255.255:0/test.jpg - didFailLoadingWithError: <NSError domain
NSURLErrorDomain, code -1004, failing URL "http://255.255.255.255:0/test.jpg">
>  http://255.255.255.255/test.jpg - willSendRequest <NSURLRequest URL
http://255.255.255.255/test.jpg, main document URL block-test.html, http method
GET> redirectResponse (null)
> -http://255.255.255.255/test.jpg - didFailLoadingWithError: <NSError domain
soup_http_error_quark, code 4, failing URL "http://255.255.255.255/test.jpg">
> +http://255.255.255.255/test.jpg - didFailLoadingWithError: <NSError domain
NSURLErrorDomain, code -1004, failing URL "http://255.255.255.255/test.jpg">
>  http://255.255.255.255/test.jpg - willSendRequest <NSURLRequest URL
http://255.255.255.255/test.jpg, main document URL block-test.html, http method
GET> redirectResponse (null)
> -http://255.255.255.255/test.jpg - didFailLoadingWithError: <NSError domain
soup_http_error_quark, code 4, failing URL "http://255.255.255.255/test.jpg">
> +http://255.255.255.255/test.jpg - didFailLoadingWithError: <NSError domain
NSURLErrorDomain, code -1004, failing URL "http://255.255.255.255/test.jpg">
>  ftp://255.255.255.255/test.jpg - willSendRequest <NSURLRequest URL
ftp://255.255.255.255/test.jpg, main document URL block-test.html, http method
GET> redirectResponse (null)
> -ftp://255.255.255.255/test.jpg - didFailLoadingWithError: <NSError domain
WebKitErrorDomain, code 101, failing URL "ftp://255.255.255.255/test.jpg">
> +ftp://255.255.255.255/test.jpg - didFailLoadingWithError: <NSError domain
NSURLErrorDomain, code -1, failing URL "ftp://255.255.255.255/test.jpg">
>  ftp://255.255.255.255/test.jpg - willSendRequest <NSURLRequest URL
ftp://255.255.255.255/test.jpg, main document URL block-test.html, http method
GET> redirectResponse (null)
> -ftp://255.255.255.255/test.jpg - didFailLoadingWithError: <NSError domain
WebKitErrorDomain, code 101, failing URL "ftp://255.255.255.255/test.jpg">
> +ftp://255.255.255.255/test.jpg - didFailLoadingWithError: <NSError domain
NSURLErrorDomain, code -1, failing URL "ftp://255.255.255.255/test.jpg">
>  ftp://255.255.255.255:22/test.jpg - willSendRequest <NSURLRequest URL
ftp://255.255.255.255:22/test.jpg, main document URL block-test.html, http
method GET> redirectResponse (null)
> -ftp://255.255.255.255:22/test.jpg - didFailLoadingWithError: <NSError domain
WebKitErrorDomain, code 101, failing URL "ftp://255.255.255.255:22/test.jpg">
> +ftp://255.255.255.255:22/test.jpg - didFailLoadingWithError: <NSError domain
NSURLErrorDomain, code -1, failing URL "ftp://255.255.255.255:22/test.jpg">

Where these changes taken from a WPE buildbot?	Seems like the test results
haven't been updated in a while (which is okay; just curious why there are so
many changes).