[webkit-reviews] review granted: [Bug 184823] REGRESSION(r230812): [WPE][GTK] WebKitWebViewSessionState.cpp throws away encoded BackForwardList identifier : [Attachment 338868] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 184823: REGRESSION(r230812): [WPE][GTK] WebKitWebViewSessionState.cpp
throws away encoded BackForwardList identifier
https://bugs.webkit.org/show_bug.cgi?id=184823

Attachment 338868: Patch

https://bugs.webkit.org/attachment.cgi?id=338868&action=review




--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 338868
  --> https://bugs.webkit.org/attachment.cgi?id=338868
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338868&action=review

> Source/WebKit/UIProcess/API/glib/WebKitWebViewSessionState.cpp:394
> +    GRefPtr<GVariant> variant;
> +    for (unsigned i = 0; sessionStateTypeStringVersions[i]; ++i) {
> +	   sessionStateTypeString = sessionStateTypeStringVersions[i];
> +	   variant =
g_variant_new_from_bytes(G_VARIANT_TYPE(sessionStateTypeString), data, FALSE);
> +	   if (g_variant_is_normal_form(variant.get()))
> +	       break;
> +	   variant = nullptr;
> +    }

You've tested this to ensure it doesn't emit a bunch of warnings or criticals
when the type doesn't match?