[webkit-reviews] review granted: [Bug 185016] [LFC] Add support for is<> and downcast<> : [Attachment 338828] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 25 16:58:32 PDT 2018


Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 185016: [LFC] Add support for is<> and downcast<>
https://bugs.webkit.org/show_bug.cgi?id=185016

Attachment 338828: Patch

https://bugs.webkit.org/attachment.cgi?id=338828&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 338828
  --> https://bugs.webkit.org/attachment.cgi?id=338828
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338828&action=review

> Source/WebCore/layout/layouttree/LayoutBox.h:117
>      bool m_isAnonymous { false };
> +
> +    unsigned m_baseTypeFlags : 3;

Since you are adding a bitfield, you could put m_isAnonymous there as well.


More information about the webkit-reviews mailing list