[webkit-reviews] review denied: [Bug 183442] WebAssembly: add support for stream APIs - JavaScript API : [Attachment 338662] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has denied GSkachkov <gskachkov at gmail.com>'s
request for review:
Bug 183442: WebAssembly: add support for stream APIs - JavaScript API
https://bugs.webkit.org/show_bug.cgi?id=183442

Attachment 338662: Patch

https://bugs.webkit.org/attachment.cgi?id=338662&action=review




--- Comment #14 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 338662
  --> https://bugs.webkit.org/attachment.cgi?id=338662
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338662&action=review

I have no comments about the functionality of the patch itself, 
but the changes to the CMake build files are breaking the EWS bots.
Please fix at least that and re-upload.

> Source/JavaScriptCore/CMakeLists.txt:1122
> +    $(JAVASCRIPTCORE_DIR)/builtins/WebAssemblyPrototype.js

Please use ${JAVASCRIPTCORE_DIR} here, with brackets, which is how CMake
variables have to be expanded. Using parentheses causes CMake to generate
invalid output that Ninja cannot parse, and this patch is breaking the
EWSs which use Ninja (like GTK+ and WPE).