[webkit-reviews] review granted: [Bug 184428] Remove access to keychain from the WebContent process : [Attachment 338763] Part 2

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 184428: Remove access to keychain from the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=184428

Attachment 338763: Part 2

https://bugs.webkit.org/attachment.cgi?id=338763&action=review




--- Comment #23 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 338763
  --> https://bugs.webkit.org/attachment.cgi?id=338763
Part 2

View in context: https://bugs.webkit.org/attachment.cgi?id=338763&action=review

Looks good!

> Source/WebKit/ChangeLog:13
> +	   macOS Keychain.

... such that WebKitTestRunner tests will not modify the underlying key store
(e.g., the macOS Keychain).

> Source/WebKitLegacy/mac/ChangeLog:13
> +	   macOS Keychain.

Ditto my comments above.