[webkit-reviews] review granted: [Bug 184985] [CMake] Require GCC 6 : [Attachment 338764] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 25 13:35:11 PDT 2018
Alex Christensen <achristensen at apple.com> has granted Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 184985: [CMake] Require GCC 6
https://bugs.webkit.org/show_bug.cgi?id=184985
Attachment 338764: Patch
https://bugs.webkit.org/attachment.cgi?id=338764&action=review
--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 338764
--> https://bugs.webkit.org/attachment.cgi?id=338764
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=338764&action=review
> Source/WTF/wtf/Compiler.h:-97
> -#if !GCC_VERSION_AT_LEAST(5, 0, 0)
> -#error "Please use a newer version of GCC. WebKit requires GCC 5.0.0 or
newer to compile."
> -#endif
Couldn't you just increment this?
More information about the webkit-reviews
mailing list