[webkit-reviews] review granted: [Bug 184962] PSON: Don't create a new process when navigating to a blob URL, data URL, and about:blank : [Attachment 338766] Made data: and about: use same process

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 184962: PSON: Don't create a new process when navigating to a blob URL,
data URL, and about:blank
https://bugs.webkit.org/show_bug.cgi?id=184962

Attachment 338766: Made data: and about: use same process

https://bugs.webkit.org/attachment.cgi?id=338766&action=review




--- Comment #8 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 338766
  --> https://bugs.webkit.org/attachment.cgi?id=338766
Made data: and about: use same process

View in context: https://bugs.webkit.org/attachment.cgi?id=338766&action=review

> Source/WebCore/ChangeLog:9
> +	   to avoid creating a new WebContent process when navigating to a blob
object URL.

s/blob object//

> Source/WebKit/UIProcess/WebPageProxy.cpp:3959
> +   
navigation->settreatAsSameOriginNavigation(navigationActionData.treatAsSameOrig
inNavigation);

s/settreatAsSameOriginNavigation/setTreatAsSameOriginNavigation/

> Source/WebKit/UIProcess/WebProcessPool.cpp:2027
> +    if (navigation.treatAsSameOriginNavigation())

Can we simplify the logic here with the lines below checking for !url.isValid()
|| url.isEmpty() || url.isBlankURL() || protocolHostAndPortAreEqual(url,
targetURL)? Maybe WebProcess could do the computation here.
I am wondering what we should do with file based origins/loads as well.

> Source/WebKit/UIProcess/API/APINavigation.h:87
> +    void settreatAsSameOriginNavigation(bool value) {
m_treatAsSameOriginNavigation = value; }

s/sett/setT/